Janady13/missionmatch / cmd/opportunity-amendment-diff/pickpair_test.go

1package main 2 3import "testing" 4 5// FINDING F6. The diff paired documents BY RECENCY: the first non amendment document became the baseline and 6// the latest amendment became the other side. On Package B that compared the SOLICITATION against the AMENDED 7// PWS, which are different documents about different things, so the five changes it reported were partly 8// artifacts of comparing unlike things. 9// 10// The safety guarantee under test at Gate A held regardless, because acceptance item 11 is that an amendment 11// FLAGS and never REWRITES an approved requirement, and that is true whichever pair is diffed. What was wrong 12// was diff QUALITY, and a diff a capture team cannot trust is a diff they will stop reading. 13// 14// THE FIX: pair WITHIN a document type, earliest against latest, preferring the type that actually carries 15// scope. Package B ships the original PWS and the amended PWS precisely so this can be got right. 16 17// THE REAL PACKAGE B SHAPE, read back from staging rather than imagined. The classifications are the ones the 18// intake actually recorded, and the important one is that 05_PWS_amended is typed AMENDMENT, not pws. 19// 20// THAT DETAIL BROKE THE FIRST FIX. Pairing purely within a document type looked correct against a fixture I 21// wrote, where both PWS documents were typed pws. Against the real data the pws type holds ONE document, so the 22// pairing fell straight through to the cross type fallback and chose the solicitation again, which is the exact 23// behaviour F6 describes. A fix verified only against a fixture of my own construction is not a fix. 24func packageB() []document { 25 return []document{ 26 {ID: "1", FileName: "01_Solicitation_W912CN26QA031_17JUL2026.pdf", DocumentType: "solicitation"}, 27 {ID: "2", FileName: "02_Amendment_0001_SF30.pdf", DocumentType: "amendment"}, 28 {ID: "3", FileName: "03_Amendment_0001_Conformed_Solicitation.pdf", DocumentType: "amendment"}, 29 {ID: "4", FileName: "04_PWS_original_10JUL26.pdf", DocumentType: "pws"}, 30 {ID: "5", FileName: "05_PWS_amended_23JUL26.pdf", DocumentType: "amendment"}, 31 {ID: "6", FileName: "06_RFC_Log_Government_Responses.pdf", DocumentType: "attachment"}, 32 } 33} 34 35// The same package if a reviewer classifies the amended PWS correctly as a pws, which the Documents screen now 36// nudges them to do. Both shapes must reach the same pair. 37func packageBWellClassified() []document { 38 docs := packageB() 39 docs[4].DocumentType = "pws" 40 return docs 41} 42 43func TestPickPairComparesTheTwoPWSWhenTheAmendedOneIsTypedAmendment(t *testing.T) { 44 base, amend, how := pickPair(packageB()) 45 if base.ID != "4" { 46 t.Errorf("baseline = %s (%s), want the ORIGINAL PWS. This is the real F6 case", base.ID, base.FileName) 47 } 48 if amend.ID != "5" { 49 t.Errorf("other side = %s (%s), want the AMENDED PWS", amend.ID, amend.FileName) 50 } 51 if how != pairCrossType { 52 t.Errorf("pairing method = %q, want %q so the report qualifies itself", how, pairCrossType) 53 } 54} 55 56func TestPickPairNeverPairsTwoUnrelatedAttachments(t *testing.T) { 57 // An earlier version ranked 'attachment' as pairable, so a package with two attachments and one PWS would 58 // have diffed the two attachments against each other. That is worse than the bug being fixed. 59 docs := []document{ 60 {ID: "1", FileName: "01_Solicitation.pdf", DocumentType: "solicitation"}, 61 {ID: "2", FileName: "02_Amendment_SF30.pdf", DocumentType: "amendment"}, 62 {ID: "3", FileName: "06_RFC_Log.pdf", DocumentType: "attachment"}, 63 {ID: "4", FileName: "07_Deliverables.pdf", DocumentType: "attachment"}, 64 } 65 base, amend, _ := pickPair(docs) 66 if base.DocumentType == "attachment" && amend.DocumentType == "attachment" { 67 t.Fatalf("paired two attachments, %s against %s", base.FileName, amend.FileName) 68 } 69} 70 71func TestPickPairComparesTheTwoPWSDocumentsOnPackageB(t *testing.T) { 72 base, amend, how := pickPair(packageBWellClassified()) 73 if base.ID != "4" { 74 t.Errorf("baseline = %s (%s), want the ORIGINAL PWS", base.ID, base.FileName) 75 } 76 if amend.ID != "5" { 77 t.Errorf("other side = %s (%s), want the AMENDED PWS", amend.ID, amend.FileName) 78 } 79 if base.DocumentType != amend.DocumentType { 80 t.Errorf("paired across types %q and %q, which is exactly finding F6", 81 base.DocumentType, amend.DocumentType) 82 } 83 if how != pairSameType { 84 t.Errorf("pairing method = %q, want %q", how, pairSameType) 85 } 86} 87 88func TestPickPairPrefersPWSOverSolicitationWhenBothHaveTwo(t *testing.T) { 89 docs := []document{ 90 {ID: "1", FileName: "sol_v1.pdf", DocumentType: "solicitation"}, 91 {ID: "2", FileName: "sol_v2.pdf", DocumentType: "solicitation"}, 92 {ID: "3", FileName: "pws_v1.pdf", DocumentType: "pws"}, 93 {ID: "4", FileName: "pws_v2.pdf", DocumentType: "pws"}, 94 } 95 base, amend, _ := pickPair(docs) 96 if base.DocumentType != "pws" || amend.DocumentType != "pws" { 97 t.Fatalf("paired %s against %s, want the PWS pair: the PWS is the document that carries the scope a "+ 98 "staffing requirement is derived from", base.DocumentType, amend.DocumentType) 99 } 100} 101 102func TestPickPairTakesEarliestAndLatestWithinTheType(t *testing.T) { 103 docs := []document{ 104 {ID: "1", FileName: "pws_a.pdf", DocumentType: "pws"}, 105 {ID: "2", FileName: "pws_b.pdf", DocumentType: "pws"}, 106 {ID: "3", FileName: "pws_c.pdf", DocumentType: "pws"}, 107 } 108 base, amend, _ := pickPair(docs) 109 if base.ID != "1" || amend.ID != "3" { 110 t.Fatalf("paired %s against %s, want earliest 1 against latest 3", base.ID, amend.ID) 111 } 112} 113 114// THE FALLBACK MUST STILL WORK, and must SAY it is a fallback. A package with a solicitation and a single 115// SF30 amendment and nothing else has no same type pair available, and refusing to diff at all would be worse 116// than a cross type diff that is labelled as one. 117func TestPickPairFallsBackAcrossTypesAndLabelsIt(t *testing.T) { 118 docs := []document{ 119 {ID: "1", FileName: "solicitation.pdf", DocumentType: "solicitation"}, 120 {ID: "2", FileName: "amendment_sf30.pdf", DocumentType: "amendment"}, 121 } 122 base, amend, how := pickPair(docs) 123 if base.ID != "1" || amend.ID != "2" { 124 t.Errorf("fallback paired %s against %s, want 1 against 2", base.ID, amend.ID) 125 } 126 if how != pairCrossType { 127 t.Errorf("pairing method = %q, want %q so the output can say the comparison is weaker", how, pairCrossType) 128 } 129} 130 131func TestPickPairReportsNothingToCompareOnASingleDocument(t *testing.T) { 132 docs := []document{{ID: "1", FileName: "only.pdf", DocumentType: "pws"}} 133 base, amend, how := pickPair(docs) 134 if how != pairNone { 135 t.Errorf("pairing method = %q, want %q", how, pairNone) 136 } 137 if base.ID != "" || amend.ID != "" { 138 t.Errorf("a single document produced a pair: %q against %q", base.ID, amend.ID) 139 } 140} 141 142func TestPickPairHandlesAnEmptySet(t *testing.T) { 143 base, amend, how := pickPair(nil) 144 if how != pairNone || base.ID != "" || amend.ID != "" { 145 t.Fatalf("empty input produced %q, %q, %q", base.ID, amend.ID, how) 146 } 147} 148 149func TestPickPairIsDeterministic(t *testing.T) { 150 for i := 0; i < 5; i++ { 151 b1, a1, h1 := pickPair(packageB()) 152 b2, a2, h2 := pickPair(packageB()) 153 if b1.ID != b2.ID || a1.ID != a2.ID || h1 != h2 { 154 t.Fatalf("pairing is not deterministic: %s/%s/%s then %s/%s/%s", b1.ID, a1.ID, h1, b2.ID, a2.ID, h2) 155 } 156 } 157} 158