Janady13/missionmatch / internal/modules/opportunities/scope_splitmerge_test.go

1package opportunities 2 3import ( 4 "errors" 5 "strings" 6 "testing" 7) 8 9// PHASE 2 ITEM 4, the two operations that were missing. Screen 4 requires accept, edit and accept, reject, 10// SPLIT, MERGE, and add manually. Four existed. These tests cover the pure validation, which is where the 11// rules that protect the citation live; the database behaviour is proven live against staging. 12// 13// THE RULE THAT MATTERS MOST: neither operation may produce an uncited machine item. A split inherits the 14// parent's citation for every child, and a merge keeps the primary's. If either invented a fresh item with no 15// source, ck_scope_items_cited would refuse it, and that refusal is the schema catching a bug rather than the 16// design working. So validation refuses it first, and the constraint stays as the backstop. 17 18func TestValidateSplitRequiresAtLeastTwoParts(t *testing.T) { 19 cases := map[string][]SplitPart{ 20 "no parts": {}, 21 "one part": {{Title: "Only one"}}, 22 } 23 for name, parts := range cases { 24 if err := validateSplit(parts); err == nil { 25 t.Errorf("%s: split accepted %d part(s). Splitting into one is an edit, not a split, and it "+ 26 "would retire the parent while changing nothing", name, len(parts)) 27 } else if !errors.Is(err, ErrInvalidInput) { 28 t.Errorf("%s: error = %v, want ErrInvalidInput", name, err) 29 } 30 } 31} 32 33func TestValidateSplitAcceptsTwoOrMore(t *testing.T) { 34 parts := []SplitPart{{Title: "Monitoring of the enclave"}, {Title: "Incident response reporting"}} 35 if err := validateSplit(parts); err != nil { 36 t.Fatalf("a legitimate two way split was refused: %v", err) 37 } 38} 39 40func TestValidateSplitRefusesAnEmptyTitle(t *testing.T) { 41 parts := []SplitPart{{Title: "Real half"}, {Title: " "}} 42 if err := validateSplit(parts); err == nil { 43 t.Fatal("a part with a blank title was accepted, which would create an unreadable scope row") 44 } 45} 46 47func TestValidateSplitRefusesAnUnknownScopeType(t *testing.T) { 48 parts := []SplitPart{{Title: "A", ScopeType: "objective"}, {Title: "B", ScopeType: "not_a_type"}} 49 if err := validateSplit(parts); err == nil { 50 t.Fatal("an out of vocabulary scope_type was accepted; the column CHECK would then refuse the write") 51 } 52} 53 54func TestValidateSplitAllowsAnEmptyScopeTypeMeaningInherit(t *testing.T) { 55 // An empty scope type is not missing data, it means keep the parent's classification. Requiring the 56 // reviewer to restate it on every child would invite them to get it wrong. 57 parts := []SplitPart{{Title: "A"}, {Title: "B"}} 58 if err := validateSplit(parts); err != nil { 59 t.Fatalf("empty scope_type should inherit from the parent, got %v", err) 60 } 61} 62 63func TestValidateSplitRefusesTooManyParts(t *testing.T) { 64 parts := make([]SplitPart, 51) 65 for i := range parts { 66 parts[i] = SplitPart{Title: "part"} 67 } 68 if err := validateSplit(parts); err == nil { 69 t.Fatal("51 parts accepted; an unbounded split is a way to flood the review queue from one item") 70 } 71} 72 73func TestValidateMergeRequiresSomethingToAbsorb(t *testing.T) { 74 if err := validateMerge("11111111-1111-1111-1111-111111111111", nil, "Combined"); err == nil { 75 t.Fatal("a merge with nothing to absorb was accepted, which is an edit wearing a merge's name") 76 } 77} 78 79func TestValidateMergeRefusesMergingAnItemIntoItself(t *testing.T) { 80 id := "11111111-1111-1111-1111-111111111111" 81 if err := validateMerge(id, []string{id}, "Combined"); err == nil { 82 t.Fatal("an item was allowed to absorb itself, which would retire the survivor and lose the item") 83 } 84} 85 86func TestValidateMergeRefusesADuplicateInTheAbsorbList(t *testing.T) { 87 a := "11111111-1111-1111-1111-111111111111" 88 b := "22222222-2222-2222-2222-222222222222" 89 if err := validateMerge(a, []string{b, b}, "Combined"); err == nil { 90 t.Fatal("a duplicated id was accepted; the second write would find the row already retired") 91 } 92} 93 94func TestValidateMergeRefusesANonUUID(t *testing.T) { 95 a := "11111111-1111-1111-1111-111111111111" 96 if err := validateMerge(a, []string{"not-a-uuid"}, "Combined"); err == nil { 97 t.Fatal("a non uuid was accepted into the absorb list") 98 } 99} 100 101func TestValidateMergeRequiresATitle(t *testing.T) { 102 a := "11111111-1111-1111-1111-111111111111" 103 b := "22222222-2222-2222-2222-222222222222" 104 if err := validateMerge(a, []string{b}, " "); err == nil { 105 t.Fatal("a merge with a blank title was accepted; the combined item must say what it now covers") 106 } 107} 108 109func TestValidateMergeAcceptsALegitimateMerge(t *testing.T) { 110 a := "11111111-1111-1111-1111-111111111111" 111 b := "22222222-2222-2222-2222-222222222222" 112 c := "33333333-3333-3333-3333-333333333333" 113 if err := validateMerge(a, []string{b, c}, "Continuous monitoring and reporting"); err != nil { 114 t.Fatalf("a legitimate three way merge was refused: %v", err) 115 } 116} 117 118// The status vocabulary must carry split, and migration 0084 adds it. A test on the map is cheap insurance 119// against someone reverting the Go side and leaving the column permitting a value the code rejects. 120func TestSplitIsAValidReviewStatus(t *testing.T) { 121 if !validScopeReviewStatuses["split"] { 122 t.Fatal("split is not an accepted review status in Go, so the API would refuse what the column permits") 123 } 124 for _, want := range []string{"extracted", "accepted", "edited", "rejected", "merged", "manual"} { 125 if !validScopeReviewStatuses[want] { 126 t.Errorf("status %q was dropped from the vocabulary; extend, never remove", want) 127 } 128 } 129} 130 131func TestSplitTitlesAreTrimmedNotRejectedForWhitespace(t *testing.T) { 132 parts := []SplitPart{{Title: " Leading and trailing "}, {Title: "Second"}} 133 if err := validateSplit(parts); err != nil { 134 t.Fatalf("surrounding whitespace should be trimmed, not refused: %v", err) 135 } 136 if strings.TrimSpace(parts[0].Title) != "Leading and trailing" { 137 t.Errorf("unexpected trim result %q", strings.TrimSpace(parts[0].Title)) 138 } 139} 140