Janady13/missionmatch / internal/modules/recruiting/messaging_test.go

1package recruiting 2 3import ( 4 "strings" 5 "testing" 6) 7 8// A placeholder must NEVER render empty. "Hi ," is worse than no personalisation, and it is the thing a 9// candidate notices instantly. 10func TestPlaceholdersNeverRenderEmpty(t *testing.T) { 11 cases := []struct { 12 name string 13 r recipient 14 want string 15 }{ 16 {"a full name", recipient{name: "Dana Reyes", email: "d@x.test"}, "Dana"}, 17 {"one word name", recipient{name: "Prince", email: "p@x.test"}, "Prince"}, 18 {"whitespace only", recipient{name: " ", email: "w@x.test"}, "there"}, 19 {"empty name", recipient{name: "", email: "e@x.test"}, "there"}, 20 } 21 for _, c := range cases { 22 got := ExpandPlaceholders("Hi {{first_name}},", c.r, "Acme") 23 if !strings.Contains(got, c.want) { 24 t.Errorf("%s: expanded to %q, expected it to contain %q", c.name, got, c.want) 25 } 26 if strings.Contains(got, "Hi ,") { 27 t.Errorf("%s: rendered an empty greeting: %q", c.name, got) 28 } 29 if strings.Contains(got, "{{") { 30 t.Errorf("%s: left an unexpanded token: %q", c.name, got) 31 } 32 } 33} 34 35func TestExpandAllPlaceholders(t *testing.T) { 36 r := recipient{name: "Dana Reyes", email: "dana@example.test"} 37 got := ExpandPlaceholders( 38 "{{first_name}}|{{full_name}}|{{email}}|{{sender_name}}", r, "Acme Recruiting") 39 want := "Dana|Dana Reyes|dana@example.test|Acme Recruiting" 40 if got != want { 41 t.Errorf("expansion wrong:\n got %q\nwant %q", got, want) 42 } 43 // Every token the system advertises must actually expand. A published placeholder that does nothing is 44 // worse than one that does not exist, because somebody will use it. 45 for _, p := range Placeholders() { 46 if out := ExpandPlaceholders(p, r, "Acme"); strings.Contains(out, "{{") { 47 t.Errorf("advertised placeholder %s did not expand, it rendered %q", p, out) 48 } 49 } 50} 51 52// A template carrying a token this system cannot fill must be REFUSED at authoring time. Letting it through 53// means a candidate receives a message with a visible curly brace in it, which reads as a broken mail merge. 54func TestUnknownPlaceholdersRefused(t *testing.T) { 55 for _, bad := range []string{ 56 "Hi {{firstname}},", "{{ first_name }}", "{{salary}}", "{{company}}", 57 "Hello {{first_name}} about {{req_title}}", 58 } { 59 if got := unknownPlaceholders(bad); got == "" { 60 t.Errorf("%q carries a token this system cannot fill and was accepted", bad) 61 } 62 } 63 for _, good := range []string{ 64 "", "Hi there", "Hi {{first_name}},", "{{first_name}} {{full_name}} {{email}} {{sender_name}}", 65 "a { single brace } is fine", 66 } { 67 if got := unknownPlaceholders(good); got != "" { 68 t.Errorf("%q is valid and was refused for %q", good, got) 69 } 70 } 71} 72 73// An unterminated token must not hang or panic. It is the input a person types halfway through editing. 74func TestUnterminatedPlaceholderTerminates(t *testing.T) { 75 done := make(chan string, 1) 76 go func() { done <- unknownPlaceholders("Hi {{first_name") }() 77 select { 78 case got := <-done: 79 if got == "" { 80 t.Error("an unterminated token should be reported, not silently accepted") 81 } 82 default: 83 // The goroutine already returned or is about to; a real hang fails the test binary's own timeout. 84 } 85 if got := unknownPlaceholders("{{"); got == "" { 86 t.Error("a bare opening token should be reported") 87 } 88} 89 90func TestTemplateValidation(t *testing.T) { 91 ok := templateRequest{Name: "First outreach", Audience: "candidate", Subject: "Hello", Body: "Hi {{first_name}},"} 92 if f, err := validTemplate(ok); err != nil { 93 t.Errorf("a valid template was refused on %q: %v", f, err) 94 } 95 cases := []struct { 96 name string 97 in templateRequest 98 field string 99 }{ 100 {"no name", templateRequest{Audience: "candidate", Body: "x"}, "name"}, 101 {"bad audience", templateRequest{Name: "n", Audience: "everyone", Body: "x"}, "audience"}, 102 {"no body", templateRequest{Name: "n", Audience: "candidate", Body: " "}, "body"}, 103 {"unknown token", templateRequest{Name: "n", Audience: "candidate", Body: "Hi {{nickname}}"}, "body"}, 104 {"oversized subject", templateRequest{Name: "n", Audience: "candidate", 105 Subject: strings.Repeat("x", 301), Body: "x"}, "subject"}, 106 } 107 for _, c := range cases { 108 f, err := validTemplate(c.in) 109 if err == nil { 110 t.Errorf("%s should be refused", c.name) 111 continue 112 } 113 if f != c.field { 114 t.Errorf("%s reported field %q, expected %q", c.name, f, c.field) 115 } 116 } 117} 118 119// A transport error can echo the credentials it was rejecting, and that text is stored on the message row and 120// returned over the API. 121func TestScrubRemovesCredentials(t *testing.T) { 122 out := scrub("535 auth failed for svc-mailer using hunter2000seven", "svc-mailer", "hunter2000seven") 123 for _, secret := range []string{"svc-mailer", "hunter2000seven"} { 124 if strings.Contains(out, secret) { 125 t.Errorf("%q survived scrubbing: %q", secret, out) 126 } 127 } 128} 129