Janady13/missionmatch / internal/integration/bid_outcomes_integration_test.go

1//go:build integration 2 3// M7 bid outcomes ledger integration. Proves at runtime against a REAL Postgres what the unit tests cannot: 4// the bid_outcomes RLS boundary (org A never sees org B's outcomes, on the table and through the advisory 5// base rate read), the recording path under the app role, and that the bid_win_rate_by_segment advisory 6// read computes the correct win rate per customer agency segment, RLS scoped, with the win rate scanned into 7// shopspring/decimal (never float64). It seeds two orgs, records outcomes for both, and asserts each org 8// sees only its own ledger and its own base rate. 9// 10// Run: go test -tags=integration ./internal/integration/ -run BidOutcomes -v 11// Env: MM_APP_DSN, MM_MIGRATOR_DSN (required). 12package integration 13 14import ( 15 "context" 16 "testing" 17 "time" 18 19 "github.com/google/uuid" 20 "github.com/jackc/pgx/v5" 21 "github.com/shopspring/decimal" 22 23 "github.com/missionworkforce/missionmatch/internal/modules/ai" 24 "github.com/missionworkforce/missionmatch/internal/modules/bidoutcomes" 25) 26 27// seedRequirementWithAgency inserts a requirement with a customer agency via the BYPASSRLS migrator, so the 28// test can wire bid outcomes to a known segment across tenants. 29func seedRequirementWithAgency(t *testing.T, org uuid.UUID, agency string) uuid.UUID { 30 t.Helper() 31 id := uuid.New() 32 if _, err := migrator.Exec(context.Background(), 33 `INSERT INTO requirements (id, organization_id, title, customer_agency, required_level, required_poly) 34 VALUES ($1,$2,$3,$4,'none','none')`, 35 id, org, "Req for "+agency, agency); err != nil { 36 t.Fatalf("seed requirement: %v", err) 37 } 38 return id 39} 40 41// recordOutcome records one bid outcome under the org's RLS session via the service (the real recording 42// path), tying it to a requirement so it carries a customer agency segment. 43func recordOutcome(t *testing.T, svc *bidoutcomes.Service, org, reqID uuid.UUID, result string) bidoutcomes.BidOutcome { 44 t.Helper() 45 out, err := svc.RecordBidOutcome(ctxOrg(org), bidoutcomes.RecordInput{ 46 RequirementID: reqID.String(), 47 Result: result, 48 SubmittedAt: time.Now().UTC().Format(time.RFC3339), 49 }) 50 if err != nil { 51 t.Fatalf("record outcome (%s): %v", result, err) 52 } 53 return out 54} 55 56// TestBidOutcomesRLSIsolation proves org A's bid_outcomes never leak into org B and vice versa, both on a 57// direct table read and through the advisory base rate read. 58func TestBidOutcomesRLSIsolation(t *testing.T) { 59 orgA, orgB := seedOrg(t), seedOrg(t) 60 reqA := seedRequirementWithAgency(t, orgA, "DISA") 61 reqB := seedRequirementWithAgency(t, orgB, "USAF") 62 svc := bidoutcomes.NewService(appDB, nil) 63 64 outA := recordOutcome(t, svc, orgA, reqA, bidoutcomes.ResultWin) 65 outB := recordOutcome(t, svc, orgB, reqB, bidoutcomes.ResultLoss) 66 67 // Org A lists its own bid_outcomes under RLS and must see only its own row. 68 var ids []uuid.UUID 69 if err := appDB.RunInTenantTx(ctxOrg(orgA), func(ctx context.Context, tx pgx.Tx) error { 70 rows, e := tx.Query(ctx, "SELECT id FROM bid_outcomes") 71 if e != nil { 72 return e 73 } 74 defer rows.Close() 75 for rows.Next() { 76 var id uuid.UUID 77 if e := rows.Scan(&id); e != nil { 78 return e 79 } 80 ids = append(ids, id) 81 } 82 return rows.Err() 83 }); err != nil { 84 t.Fatalf("list org A outcomes: %v", err) 85 } 86 sawA, sawB := false, false 87 for _, id := range ids { 88 sawA = sawA || id.String() == outA.ID 89 sawB = sawB || id.String() == outB.ID 90 } 91 if !sawA { 92 t.Fatal("org A must see its own bid outcome") 93 } 94 if sawB { 95 t.Fatal("ISOLATION BREACH: org A saw org B's bid outcome") 96 } 97 98 // A direct read of B's outcome under org A's session must return zero rows (RLS hides it). 99 var n int 100 if err := appDB.RunInTenantTx(ctxOrg(orgA), func(ctx context.Context, tx pgx.Tx) error { 101 return tx.QueryRow(ctx, "SELECT count(*) FROM bid_outcomes WHERE id = $1", outB.ID).Scan(&n) 102 }); err != nil { 103 t.Fatalf("cross tenant read: %v", err) 104 } 105 if n != 0 { 106 t.Fatalf("ISOLATION BREACH: org A read org B's outcome by id (count %d)", n) 107 } 108} 109 110// TestBidWinRateBaseRatePerAgency proves the advisory base rate read returns the correct win rate per 111// customer agency segment for the caller's own ledger, and that a second org sees only its own base rate. 112// Org A records, for DISA, two wins and one loss (win rate 2/3), and for USAF one win and one loss (win 113// rate 1/2); a pending bid is excluded from the decided denominator. Org B records a single DISA loss, so 114// its DISA win rate is 0/1, proving the read is RLS scoped and never blends the two tenants. 115func TestBidWinRateBaseRatePerAgency(t *testing.T) { 116 orgA, orgB := seedOrg(t), seedOrg(t) 117 disaA := seedRequirementWithAgency(t, orgA, "DISA") 118 usafA := seedRequirementWithAgency(t, orgA, "USAF") 119 disaB := seedRequirementWithAgency(t, orgB, "DISA") 120 svc := bidoutcomes.NewService(appDB, nil) 121 122 // org A: DISA 2 wins + 1 loss (+ 1 pending, excluded), USAF 1 win + 1 loss. 123 recordOutcome(t, svc, orgA, disaA, bidoutcomes.ResultWin) 124 recordOutcome(t, svc, orgA, disaA, bidoutcomes.ResultWin) 125 recordOutcome(t, svc, orgA, disaA, bidoutcomes.ResultLoss) 126 recordOutcome(t, svc, orgA, disaA, bidoutcomes.ResultPending) 127 recordOutcome(t, svc, orgA, usafA, bidoutcomes.ResultWin) 128 recordOutcome(t, svc, orgA, usafA, bidoutcomes.ResultLoss) 129 // org B: a single DISA loss. 130 recordOutcome(t, svc, orgB, disaB, bidoutcomes.ResultLoss) 131 132 gotA := readBaseRate(t, orgA) 133 assertSegment(t, gotA, "DISA", 2, 3, decimal.RequireFromString("0.6666666666666667")) 134 assertSegment(t, gotA, "USAF", 1, 2, decimal.RequireFromString("0.5")) 135 136 gotB := readBaseRate(t, orgB) 137 if _, ok := gotB["USAF"]; ok { 138 t.Fatal("ISOLATION BREACH: org B base rate carries org A's USAF segment") 139 } 140 assertSegment(t, gotB, "DISA", 0, 1, decimal.Zero) 141} 142 143// segmentRow is one row of the advisory base rate read. 144type segmentRow struct { 145 winCount int64 146 totalDecided int64 147 winRate *decimal.Decimal // NULL (nil) when no decided bid 148} 149 150// readBaseRate runs the registered bid_win_rate_by_segment intent SQL under the org's RLS session and scans 151// each row, proving the win rate scans into shopspring/decimal (never float64). It uses the SQL straight 152// from the closed AI Registry so the test exercises the exact reviewed read. 153func readBaseRate(t *testing.T, org uuid.UUID) map[string]segmentRow { 154 t.Helper() 155 intent, ok := ai.IntentByName(ai.IntentBidWinRateBySegment) 156 if !ok { 157 t.Fatal("bid_win_rate_by_segment intent is not registered") 158 } 159 out := map[string]segmentRow{} 160 if err := appDB.RunInTenantTx(ctxOrg(org), func(ctx context.Context, tx pgx.Tx) error { 161 rows, e := tx.Query(ctx, intent.SQL) 162 if e != nil { 163 return e 164 } 165 defer rows.Close() 166 for rows.Next() { 167 var ( 168 agency string 169 sr segmentRow 170 ) 171 if e := rows.Scan(&agency, &sr.winCount, &sr.totalDecided, &sr.winRate); e != nil { 172 return e 173 } 174 out[agency] = sr 175 } 176 return rows.Err() 177 }); err != nil { 178 t.Fatalf("base rate read for org: %v", err) 179 } 180 return out 181} 182 183// assertSegment checks one segment's win count, decided total, and win rate (to a tolerance, since the SQL 184// numeric division carries many digits). 185func assertSegment(t *testing.T, got map[string]segmentRow, agency string, wantWin, wantDecided int64, wantRate decimal.Decimal) { 186 t.Helper() 187 sr, ok := got[agency] 188 if !ok { 189 t.Fatalf("segment %q missing from base rate", agency) 190 } 191 if sr.winCount != wantWin || sr.totalDecided != wantDecided { 192 t.Fatalf("segment %q win/decided = %d/%d, want %d/%d", agency, sr.winCount, sr.totalDecided, wantWin, wantDecided) 193 } 194 if sr.winRate == nil { 195 t.Fatalf("segment %q win rate is NULL, want %s", agency, wantRate) 196 } 197 if sr.winRate.Sub(wantRate).Abs().GreaterThan(decimal.RequireFromString("0.0001")) { 198 t.Fatalf("segment %q win rate = %s, want ~%s", agency, sr.winRate, wantRate) 199 } 200} 201